Conversation
temporal-nick
approved these changes
Aug 20, 2025
metrics/prometheus_defs.go
Outdated
| MuxErrors = DefaultCounterVec("mux_errors", "Number of errors observed from mux", muxManagerLabels...) | ||
| MuxConnectionEstablish = DefaultCounterVec("mux_connection_establish", "Number of times mux has established", muxManagerLabels...) | ||
|
|
||
| translationLabels = []string{"kind", "message"} |
Collaborator
There was a problem hiding this comment.
what about message_type or msg_type instead of just "message"? I was briefly worried this was going to be like 100+ chars long
Contributor
Author
There was a problem hiding this comment.
updated to message_type
hai719
pushed a commit
to hai719/s2s-proxy
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporal_s2s_proxy_translation_success{kind="", message_type=""}temporal_s2s_proxy_translation_error{kind="", message_type=""}Labels:
kind: The kind of translation. One ofnamespace,search-attribute, orutf8repair(or possibly others added in the future)message_type: The message typeExamples
utf8repairon one proxynamespaceandutf8repairon another proxyWhy?
Checklist
Closes
How was this tested:
Local manual test.