Do not return EOF directly, returning nil will send EOF to client#142
Merged
temporal-nick merged 2 commits intomainfrom Aug 25, 2025
Merged
Do not return EOF directly, returning nil will send EOF to client#142temporal-nick merged 2 commits intomainfrom
temporal-nick merged 2 commits intomainfrom
Conversation
pglass
approved these changes
Aug 25, 2025
hai719
pushed a commit
to hai719/s2s-proxy
that referenced
this pull request
Nov 24, 2025
…mporalio#142) * Do not return EOF directly, returning nil will send EOF to client * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed the code that tries to manually send EOF to the client.
Why?
gRPC will handle sending io.EOF itself when the stream handler exits, and if you try to return an EOF yourself, gRPC will actually wrap that in UnknownError, which is not at all what we wanted here.