Improve metrics and logs. Have MuxManager.Start wait 1m so that muxes are connected before we start outbound server.#164
Merged
temporal-nick merged 1 commit intomainfrom Oct 9, 2025
Conversation
… are connected before we start outbound server.
pglass
approved these changes
Oct 9, 2025
| // The AdminServiceStreams will duplicate the same output for an underlying connection issue hundreds of times. | ||
| // Limit their output to three times per minute | ||
| logger = log.NewThrottledLogger(log.With(logger, common.ServiceTag(serviceName)), | ||
| func() float64 { return 3.0 / 60.0 }) |
Contributor
There was a problem hiding this comment.
Would be good to make the rate configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
These changes were part of a debug session investigating zombie connections on the mux server. Unfortunately the source hasn't been identified yet, but these changes will make the proxy easier to operate in the future.