Conversation
pglass
commented
Jun 4, 2025
| type ( | ||
| TranslationInterceptor struct { | ||
| logger log.Logger | ||
| translators []Translator |
Contributor
Author
There was a problem hiding this comment.
Basic idea is we could have a translator in this list for namespace name and another for cluster name translation
hehaifengcn
approved these changes
Jun 4, 2025
| ) | ||
| } | ||
|
|
||
| if len(translators) > 0 { |
Collaborator
There was a problem hiding this comment.
instead of check len(translators), can we just move interceptor.NewTranslationInterceptor up and check if tr != nil?
Contributor
Author
There was a problem hiding this comment.
Plan is to also support adding cluster name translation to the list of translators - see subsequent PR: https://github.com/temporalio/s2s-proxy/pull/88/files#diff-1d74870266949f1927a500e5f0002617239d3e3cd9bcceee6be014738e5e0f2bR56-R74
So only want to call interceptor.NewTranslationInterceptor if translators is non empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
NamespaceNameTranslatorinterceptor with more genericTranslationInterceptorTranslationInterceptorsupports a list of basicTranslatorsand we can more easily add additional translators (like for cluster name translation)Why?
Checklist
Closes
How was this tested: