SSL-enabled WorkflowClient with CA cert as param and overriding authority name#448
Merged
tsurdilo merged 6 commits intotemporalio:mainfrom Jun 26, 2023
Merged
Conversation
|
|
Contributor
|
@Aymalla thanks for the pr! |
Contributor
Author
Contributor
|
@Aymalla hi yeah it looks good. I think the project structure changed since this pr was opened. Mind rebasing and adding it to the "core" dir? Thanks. |
…/temporal-samples-java into aym/sslcontext-custom-ca
Contributor
|
Hi, not sure the rebase was correct? Maybe better to update main branch and then add your changes in a new pr? Wdyt |
Contributor
Author
|
@tsurdilo merge is Done |
tsurdilo
approved these changes
Jun 21, 2023
Contributor
|
Thanks for merging. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
A new sample has been added (ssl/SslEnabledWorkerCustomCA) that shows how to start a WorkflowClient that connects to temporal cluster with mTLS enabled created by (tls-simple sample);
SslEnabledWorkerCustomCA demonstrates:
Why?
To help developers to create mTLS enabled local dev environment using tls-simple sample to test their workflows.
Address help for issues like:
https://community.temporal.io/t/how-to-disable-host-name-verification/2808
https://community.temporal.io/t/how-to-set-tls-server-for-java-sdk-connection-option/6575
Checklist
Closes
How was this tested:
Manually using these steps mentioned in ssl/ReadME.md samples/ssl/ReadME.md