SpringBoot - Sync Update Example

[tsurdilo]

Sync Update SpringBoot Sample

This sample shows how to use update feature. Uses jpa and h2 in-memory db for the inventory.
User can enter a fishing item to purchase from inventory and define the amount.
The update validator checks if inventory has item and the amount (local activity)
The update then updates the db (local activity).

If amount you wan to purchase is > than whats in inventory the validator fails and shows message.
On success purchase the inventory table is updated dynamically..

(this pr also includes small changes to other sample html pages, like using fragments for header and footer)

[Quinn-With-Two-Ns]

Local activities cannot be run in validators

[Quinn-With-Two-Ns]

they have the same restriction as queries

[tsurdilo]

it works as in it gets called ok. didnt see failure

[Quinn-With-Two-Ns]

it is not supported and It will not replay correctly

[tsurdilo]

here is event history that shows that local activity called in validator does get executed if that helps.
this is the path when you enter in amount thats greater than that in inventory:

[bergundy]

We'll likely not support local activities in validators but there has been talk of adding a different concept to SDKs which is backed by activities but doesn't generate history events that can be used in both query handlers and update validators.

[bergundy]

We should throw in Java (and Go) if any commands are being generated in query handlers and update validators (and side-effects FTR).

[Quinn-With-Two-Ns]

ok. should we then open issue for it in java sdk to throw error and not allow temporal apis?

Yes, we already do

just wanted to add, having to throw TemporalFailure from update handler is weird

Do you have a suggestion on how you would implement it differently? I think the issue is your thinking of the update handler as part of the workflow like signal, but really its another sub request running inside a workflow that can succeed/fail on its own.

[tsurdilo]

I think if its possible to have a specific error idk like RejectUpdateException or something like that would be easier for users to understand (and if you throw TemporalFailure for it to still fail workflow if user really wants to do that for some reason).

[Quinn-With-Two-Ns]

So that doesn't really work because if you ran an activity in a update handle and it failed by default if would fail your whole workflow instead of just your update request.

[tsurdilo]

@Quinn-With-Two-Ns made all the updates let me know if its ok to get this in now (sorry im asking just have a Kafka sample coming in and wanted to get this merged fist if possible :) )