Samples for Standalone Activities [DO NOT MERGE]#778
Open
GregoryTravis wants to merge 3 commits intomainfrom
Open
Samples for Standalone Activities [DO NOT MERGE]#778GregoryTravis wants to merge 3 commits intomainfrom
GregoryTravis wants to merge 3 commits intomainfrom
Conversation
GregoryTravis
requested review from
a team,
antmendoza and
tsurdilo
as code owners
GregoryTravis
commented
Apr 28, 2026
| otelVersion = '1.30.1' | ||
| otelVersionAlpha = "${otelVersion}-alpha" | ||
| javaSDKVersion = '1.34.0' | ||
| javaSDKVersion = '1.35.0' |
chris-olszewski
approved these changes
Apr 29, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Nothing blocking, unsure about usefulness of tests here, but no harm in including them.
| otelVersion = '1.30.1' | ||
| otelVersionAlpha = "${otelVersion}-alpha" | ||
| javaSDKVersion = '1.34.0' | ||
| javaSDKVersion = '1.35.0' |
Comment on lines
+23
to
+25
| * <p>Standalone Activities do not use a Workflow at runtime, but the embedded test server only | ||
| * supports Activity execution through a Workflow. These tests therefore drive the Activity through | ||
| * a minimal wrapper Workflow so the Activity logic is exercised against the real SDK worker stack. |
Member
There was a problem hiding this comment.
Not exactly sure what these tests are actually exercising since they aren't leveraging SAA. Just that the activity implementation is sound?
Author
There was a problem hiding this comment.
Yeah, these are just a basic smoke test to make sure that the samples don't decay when changes are made in the other repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples for Standalone Activities #2741
Includes both
HelloStandaloneActivityand a full set of examples incore/src/main/java/io/temporal/samples/standaloneactivities.Tests for both.