fix: increase create-namespace retry attempts and make timeout configurable#142
Merged
chaptersix merged 1 commit intomainfrom Apr 10, 2026
Merged
fix: increase create-namespace retry attempts and make timeout configurable#142chaptersix merged 1 commit intomainfrom
chaptersix merged 1 commit intomainfrom
Conversation
…urable Hardcoded 3 health check attempts (~45s total) was not enough for the Temporal server to fully initialize its membership ring, causing context deadline exceeded errors in temporal-create-namespace. Increases default to 30 attempts (2.5 min at 5s intervals) and exposes TEMPORAL_HEALTH_CHECK_MAX_ATTEMPTS and TEMPORAL_HEALTH_CHECK_SLEEP_SECONDS env vars for overriding. Also adds retry loops to the port wait and namespace create steps which previously had no retry at all. Fixes #136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Problem
temporal-create-namespacewas hardcoded to 3 health check attempts (~45 seconds total). On slower machines or fresh setups, the Temporal server takes longer to fully initialize its membership ring — so the script exhausts its retries and exits before the server is ready.The existing
temporalcontainer healthcheck usesnc -z localhost 7233, which only checks TCP connectivity. The port opens before the membership ring stabilizes, soservice_healthyfires too early andtemporal-create-namespacestarts against a server that isn't truly ready.Fix
TEMPORAL_HEALTH_CHECK_MAX_ATTEMPTSandTEMPORAL_HEALTH_CHECK_SLEEP_SECONDSenv vars for overridingnccall with no retry)