Added Standalone Activities sample#462
Merged
maciejdudko merged 6 commits intotemporalio:mainfrom May 5, 2026
Merged
Conversation
maciejdudko
force-pushed
the
standalone-activities
branch
from
a9f98b2 to
0de0501
Compare
THardy98
approved these changes
May 5, 2026
Comment on lines
+12
to
+20
| const { count } = await client.activity.count(query); | ||
| console.log(`Total activities: ${count}`); | ||
|
|
||
| console.log('ACTIVITY ID | RUN ID | ACTIVITY TYPE | STATUS | COMPLETED TIME'); | ||
|
|
||
| for await (const a of client.activity.list(query)) { | ||
| console.log( | ||
| `${a.activityId} | ${a.activityRunId} | ${a.activityType} | ${a.status} | ${a.closeTime?.toISOString()}`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Nit: is there a reason we don't do:
const listActivities = await client.activity.list(query);
console.log(`Total activities: ${listActivities.length});
console.log('ACTIVITY ID | RUN ID | ACTIVITY TYPE | STATUS | COMPLETED TIME');
for (const a of listActivities) { ... }
Could be TOCTOU between client.activity.count and client.activity.list
Contributor
Author
There was a problem hiding this comment.
We are demonstrating both the list and the count APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sample demonstrating use of Standalone Activities APIs.