Use deployment_build_id as part of key for eager workflow start #1042
+314
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sushisource
reviewed
Oct 24, 2025
| .any(|(_, opt)| { | ||
| opt.as_ref() == build_id.as_ref() | ||
| }) | ||
| && !skip_client_worker_set_check |
| let worker_id = worker_list.choose(&mut rand::rng()); | ||
| if let Some(worker_entry) = worker_id | ||
| && let Some(worker) = self.all_workers.get(&worker_entry.0) | ||
| && let Some(slot) = worker.try_reserve_wft_slot() |
Member
There was a problem hiding this comment.
In principle we should then try the next worker in the list if this reservation fails. In practice I doubt this is going to come up much. Probably not hard to add, but maybe annoying to test.
Contributor
Author
There was a problem hiding this comment.
Right, added the retry mechanism, and codex helped me write a solid test, with some minor tweaking/fixing of course
…t worker if reservation fails, added a test
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sushisource
approved these changes
Oct 24, 2025
Comment on lines
108
to
109
| worker_list | ||
| .choose_multiple(&mut rng, worker_list.len()) |
Member
There was a problem hiding this comment.
I I think can be written more readably as worker_list.as_slice().shuffle()
https://docs.rs/rand/latest/rand/seq/trait.SliceRandom.html#tymethod.shuffle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
deployment_build_idas key for eager workflow slotWhy?
Valid use case that today causes an error
Checklist
Closes
How was this tested:
Note
Eager slot management now keys by namespace/task_queue/build_id, allows multiple local workers per queue with randomized selection/retry, updates duplicate-registration rules, and adds
randdependency.namespace+task_queue+deployment_build_id(storeVec<(Uuid, Option<String>)>), allowing multiple providers per queue when build IDs differ.namespace/task_queue/build_id; error message updated. Unregister removes only the specific worker and cleans up when empty.num_providersnow counts total providers across keys.WorkflowOptions.enable_eager_workflow_startdoc note updated to remove BuildID incompatibility warning (still experimental).randfor provider selection shuffling.Written by Cursor Bugbot for commit 427dd96. This will update automatically on new commits. Configure here.