Skip to content

Use deployment_build_id as part of key for eager workflow start #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 24, 2025
Merged

Use deployment_build_id as part of key for eager workflow start #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b320592
Use build_id as key for slot
yuandrew Oct 23, 2025
a823581
Don't pass deployment options into start workflow
yuandrew Oct 23, 2025
8e405ae
Add test
yuandrew Oct 23, 2025
c7f8801
Fix build_id comparison for slot_providers, try to reserve a differen…
yuandrew Oct 24, 2025
348bdc4
Fix unregister logic, add another test for slot boundary and retrying
yuandrew Oct 24, 2025
74fc4fc
use shuffle for clarity
yuandrew Oct 24, 2025
427dd96
Merge branch 'master' into build-id-into-slot-supplier
yuandrew Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ tower = { version = "0.5", features = ["util"] }
tracing = "0.1"
url = "2.5"
uuid = { version = "1.18", features = ["v4"] }
rand = "0.9.2"

[dependencies.temporalio-common]
path = "../common"
Expand Down
2 changes: 1 addition & 1 deletion crates/client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ pub struct WorkflowOptions {
pub search_attributes: Option<HashMap<String, Payload>>,

/// Optionally enable Eager Workflow Start, a latency optimization using local workers
/// NOTE: Experimental and incompatible with versioning with BuildIDs
/// NOTE: Experimental
pub enable_eager_workflow_start: bool,

/// Optionally set a retry policy for the workflow
Expand Down
3 changes: 1 addition & 2 deletions crates/client/src/raw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,8 +659,7 @@ proxier! {
} else {
temporalio_common::protos::temporal::api::enums::v1::WorkerVersioningMode::Unversioned.into()
},
});
}
}); }
slot = Some(reservation.slot);
}
None => req_mut.request_eager_execution = false
Expand Down
Loading
Loading