Rename WorkerShutdown to BumpStream, also handle shutdown() case #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
reviewed
Nov 10, 2025
| None | ||
| } | ||
| LocalInputs::WorkerShutdown => { | ||
| LocalInputs::BumpStream => { |
Contributor
There was a problem hiding this comment.
Comment here needs some touch ups to properly align with the change in name.
Sushisource
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Rename WorkerShutdown to BumpStream, also handle shutdown() case
Why?
merged #1055 before spencer got his PR feedback in
Checklist
Closes
How was this tested:
Note
Renames the workflow local input from
WorkerShutdowntoBumpStreamand uses it to bump/resolve pending activation polls, including during shutdown.LocalInputs::WorkerShutdown→LocalInputs::BumpStream, update all matches and comments inworkflow_stream.rs.send_worker_shutdown()withbump_stream()inWorkflows; adjust docs and call sites.bump_stream()to drive the workflow stream duringWorkflows::shutdown()instead of polling state;Worker::initiate_shutdown()now pushes a bump to unblock activation polls.Written by Cursor Bugbot for commit 2572c62. This will update automatically on new commits. Configure here.