Skip to content

Remove check between worker_types and max_cached_workflows #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuandrew merged 3 commits into from
Nov 18, 2025
Merged

Remove check between worker_types and max_cached_workflows #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7277b8
Remove check to decrease breaks
yuandrew Nov 18, 2025
c882a37
remove test for this check
yuandrew Nov 18, 2025
8e28e97
Merge branch 'master' into remove-max_cached_workflows-check
yuandrew Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions crates/common/src/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,17 +317,6 @@ impl WorkerConfigBuilder {
return Err("`max_outstanding_nexus_tasks` must be > 0".to_owned());
}

// Validate workflow cache is consistent with task_types
if !task_types.enable_workflows
&& let Some(cache) = self.max_cached_workflows.as_ref()
&& *cache > 0
{
return Err(
"Cannot have `max_cached_workflows` > 0 when workflows are not enabled in `task_types`"
.to_owned(),
);
}

if let Some(cache) = self.max_cached_workflows.as_ref()
&& *cache > 0
{
Expand Down
21 changes: 0 additions & 21 deletions crates/common/tests/worker_task_types_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,27 +49,6 @@ fn test_empty_task_types_fails_validation() {
);
}

#[test]
fn test_workflow_cache_without_workflows_fails() {
let result = WorkerConfigBuilder::default()
.namespace("default")
.task_queue("test-queue")
.versioning_strategy(default_versioning_strategy())
.task_types(WorkerTaskTypes::activity_only())
.max_cached_workflows(10usize)
.build();

assert!(
result.is_err(),
"Workflow cache > 0 without workflows should fail"
);
let err = result.err().unwrap().to_string();
assert!(
err.contains("max_cached_workflows"),
"Error should mention max_cached_workflows: {err}",
);
}

#[test]
fn test_all_combinations() {
let combinations = [
Expand Down
Loading