Emit GrpcMessageTooLarge as failure_reason for WFT #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Dec 1, 2025
| FailureReason::Timeout => "timeout".to_owned(), | ||
| FailureReason::NexusOperation(op) => format!("operation_{op}"), | ||
| FailureReason::NexusHandlerError(op) => format!("handler_error_{op}"), | ||
| FailureReason::GrpcMessageTooLarge => "GrpcMessageTooLarge".to_owned(), |
Member
There was a problem hiding this comment.
I guess this can't be snake case because it was already like this in the other SDKs? Do we already have released versions with it like that? Otherwise it'd be good to make them all snake case since that's more standard
Contributor
Author
There was a problem hiding this comment.
Yeah and the other two ones for workflows are NonDeterminismError and WorkflowError and those not snake case
|
|
||
| #[tokio::test] | ||
| async fn oversize_grpc_message() { | ||
| use crate::common::{ANY_PORT, NAMESPACE, prom_metrics}; |
Member
There was a problem hiding this comment.
These first two imports appear unused? I also generally try to avoid these scoped imports
Contributor
Author
There was a problem hiding this comment.
Yeah I removed them
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the workflow task failure is due to gRPC message too large, set GrpcMessageTooLarge as
failure_reasonontemporal_workflow_task_execution_failed.closes #1065
Note
Adds a specific failure_reason label GrpcMessageTooLarge to workflow task failure metrics when WFT completion hits an oversized gRPC message and records the metric.
FailureReason::GrpcMessageTooLargeand support emittingfailure_reasonviametrics::failure_reason(...).metrics: MetricsContextinWorkflowsand, oncomplete_workflow_taskerror flaggedMESSAGE_TOO_LARGE_KEY, fail the WFT withGrpcMessageTooLargecause and recordwf_task_failedwithfailure_reason="GrpcMessageTooLarge".oversize_grpc_messageintegration test to enable Prometheus and assert thetemporal_workflow_task_execution_failedmetric includesfailure_reason="GrpcMessageTooLarge".Written by Cursor Bugbot for commit cdf0c95. This will update automatically on new commits. Configure here.