Asyncify public APIs #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Mar 26, 2021
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Seems like it was an easy transition, nice!
| @@ -1,4 +1,4 @@ | |||
| FROM rust:1.50 | |||
| FROM rust:1.51 | |||
vitarb
approved these changes
Mar 26, 2021
Sushisource
added a commit
to Sushisource/sdk-core
that referenced
this pull request
Apr 1, 2021
* Asyncify public APIs * Fix waitloop problem while doing shutdown * A few crate updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Public Core APIs are now async
Why?
We wanted to have separate APIs for workflow and activity polling, and in order to support single-threaded language SDKs, as well as for ergonomics reasons, using an async API makes sense.
Closes issue:
Fixes #75
How has this been tested?
Existing tests updated and pass
Any docs updates needed?