Use async core interface #56
Conversation
|
Blocked on temporalio/sdk-core#80 |
packages/worker/native/src/lib.rs
Outdated
| /// Send an error to JS via callback using an [EventQueue] | ||
| fn send_error<T>(queue: Arc<EventQueue>, callback: Root<JsFunction>, error: T) | ||
| where | ||
| T: ::std::fmt::Display + Send + 'static, |
There was a problem hiding this comment.
You don't need the leading :: for these.
There was a problem hiding this comment.
Habit I picked up, I don't mind getting rid of it.
| }; | ||
| let queue = Arc::new(cx.queue()); | ||
|
|
||
| std::thread::spawn(move || { |
There was a problem hiding this comment.
Would be great to break up this big closure into smaller functions
packages/worker/native/src/lib.rs
Outdated
| if matches!(request, Request::BreakPoller) { | ||
| break; | ||
| } else if matches!(request, Request::Shutdown) { |
There was a problem hiding this comment.
This reads a bit strange compared to just a match expression
There was a problem hiding this comment.
I think you'll like the new structure
packages/worker/native/src/lib.rs
Outdated
| // Ignore BreakPoller and Shutdown, they're handled above | ||
| Request::BreakPoller => {} | ||
| Request::Shutdown => {} |
There was a problem hiding this comment.
Can be Request::BreakPoller | Request::Shutdown
| let worker = cx.argument::<BoxedWorker>(0)?; | ||
| let queue_name = cx.argument::<JsString>(1)?.value(&mut cx); | ||
| let callback = cx.argument::<JsFunction>(2)?; |
There was a problem hiding this comment.
You could impl some kind of unpack function on FunctionContext that would de-dupe these preambles and make things a bit more readable
There was a problem hiding this comment.
You'd have to show me what you mean.
There was a problem hiding this comment.
@bergundy Something like this
trait FnContextExt {
fn unpack(self) -> (BoxedWorkerType, QueueNameType, CallbackType);
}
impl FnContextExt for FunctionContext {
/// Implement the three lines here and return 3-tuple (or a real struct)
}
packages/worker/native/src/lib.rs
Outdated
| /// Send an error to JS via callback using an [EventQueue] | ||
| fn send_error<T>(queue: Arc<EventQueue>, callback: Root<JsFunction>, error: T) | ||
| where | ||
| T: ::std::fmt::Display + Send + 'static, |
There was a problem hiding this comment.
Habit I picked up, I don't mind getting rid of it.
| }; | ||
| let queue = Arc::new(cx.queue()); | ||
|
|
||
| std::thread::spawn(move || { |
packages/worker/native/src/lib.rs
Outdated
| if matches!(request, Request::BreakPoller) { | ||
| break; | ||
| } else if matches!(request, Request::Shutdown) { |
There was a problem hiding this comment.
I think you'll like the new structure
packages/worker/native/src/lib.rs
Outdated
| // Ignore BreakPoller and Shutdown, they're handled above | ||
| Request::BreakPoller => {} | ||
| Request::Shutdown => {} |
| let worker = cx.argument::<BoxedWorker>(0)?; | ||
| let queue_name = cx.argument::<JsString>(1)?.value(&mut cx); | ||
| let callback = cx.argument::<JsFunction>(2)?; |
There was a problem hiding this comment.
You'd have to show me what you mean.
Implements the Worker part of [proposal #56](https://github.com/temporalio/proposals/blob/050825aba0e2e6cde91bae81945dce082bd47622/typescript/connections.md) - Break down `Core` into `Runtime` and `NativeConnection` - Workers now require a `NativeConnection` instance instead of using the singleton `Core` connection - `Runtime` may be removed in the future but remains in the SDK to enable log forwarding from Core - By default we don't forward Core logs into node anymore This PR uses `sdk-core/master` which unblocks local activities and upsert search attributes, the last missing pieces for a feature complete SDK (apart from stack trace query).
What was changed:
Use the async core interface introduced in temporalio/sdk-core#77
Worker is now created with the static async
Worker.createmethod.How has this been tested?
Ran the existing tests which needed some modifications.
Any docs updates needed?
Docs were updated.