Write sdk name & version to WFT completes #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 22, 2025
core/src/internal_flags.rs
Outdated
Comment on lines
179
to
183
| if last_sdk_name != sdk_name || last_sdk_version != sdk_version { | ||
| (sdk_name.clone(), sdk_version.clone()) | ||
| } else { | ||
| ("".to_owned(), "".to_owned()) | ||
| }; |
Member
There was a problem hiding this comment.
I think other SDKs (and mentioned at temporalio/features#321) compare name and version independently, meaning if the version upgraded but not the SDK, only the version is written.
Member
Author
There was a problem hiding this comment.
Well, that wouldn't be totally independent, since it wouldn't make sense the other way around (although I suppose it is benign, just hard to read), but, yeah can do
Member
There was a problem hiding this comment.
Thanks! I think technically the other SDK impls are independent meaning if in some strange world you are able to switch from Go to Java but keep the version number, the version is unchanged.
cretz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Title. Automatically derived from client settings, no lang-visible change needed.
Why?
Parity, useful for investigations
Checklist
Closes [Feature Request] Update sdk-name and sdk-version in task-level metadata if changed #588
How was this tested: