test(client): fix race in activity interceptor test#693
Merged
Conversation
jmaeagle99
force-pushed
the
interceptor-tests
branch
from
13994c1 to
f0074d0
Compare
jmaeagle99
force-pushed
the
interceptor-tests
branch
from
f0074d0 to
6b35b9c
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Split terminate interceptor checks into their own test.
Why?
StartActivityAsync_Interceptors_AreCalledProperlyis frequently failing due to a race condition between cancelling the activity and terminating it. Cannot terminate an activity that is already cancelled.Checklist
Closes [Bug] Investigate
StartActivityAsync_Interceptors_AreCalledProperlyflake #648How was this tested: New tests
Any docs updates needed? No