Enforce heartbeat timeout in test environment #2144
+231
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the test environment did not enforce heartbeat timeout for activities. When an activity ran longer than HeartbeatTimeout without sending heartbeats, the test would pass instead of failing with a heartbeat timeout error. Changes: - Add heartbeat timeout tracking fields to testActivityHandle - Start heartbeat monitoring goroutine when HeartbeatTimeout > 0 - Update lastHeartbeatTime when heartbeat is received - Return TIMEOUT_TYPE_HEARTBEAT error when timeout occurs - Add three new tests to verify the fix Fixes temporalio#1282
mfateev
force-pushed
the
task/heartbeat-timeout-testing
branch
from
ae8cf26 to
2c3a26f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestWorkflowEnvironment)HeartbeatTimeoutnow correctly fail withTimeoutTypeHeartbeatProblem
The Go SDK test environment did not enforce heartbeat timeout for activities during unit testing. When an activity ran longer than the configured
HeartbeatTimeoutwithout sending heartbeats, the test would pass instead of failing.Fixes #1282
Implementation
ExecuteActivitythat checks for timeoutmockHeartbeatFnto track last heartbeat timeheartbeatTimeoutResulttype to signal heartbeat timeout failureshandleActivityResultto convert heartbeat timeout to proper errorTest plan
Test_ActivityHeartbeatTimeout- activity without heartbeating times outTest_ActivityHeartbeatTimeout_WithHeartbeat- activity with regular heartbeats succeedsTest_ActivityHeartbeatTimeout_WithDetails- heartbeat details are preserved on timeout