Revert "Upgrade go.opentelemetry.io/otel/sdk to v1.40.0"#2221
Merged
Revert "Upgrade go.opentelemetry.io/otel/sdk to v1.40.0"#2221
Conversation
This reverts commit 29de23f.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if assert.NotNil(c, d.SearchAttributes) { | ||
| assert.Equal(c, 2, len(d.SearchAttributes.IndexedFields)) | ||
| } | ||
| assert.Equal(c, 2, len(d.SearchAttributes.IndexedFields)) |
There was a problem hiding this comment.
Nil pointer dereference panic on SearchAttributes access
Medium Severity
The revert removes the if assert.NotNil(c, d.SearchAttributes) guard before accessing d.SearchAttributes.IndexedFields. Since SearchAttributes is a *commonpb.SearchAttributes (pointer type), if it's nil, calling len(d.SearchAttributes.IndexedFields) will panic with a nil pointer dereference instead of producing a clean test failure. This occurs at four locations in the test.
Additional Locations (2)
jmaeagle99
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2218
CI has become too flaky, reverting so I can get v1.41.0 out the door, will spend more time debugging the flakes that this change reveals later this week.
Note
Medium Risk
Moderate risk due to broad dependency/toolchain downgrades that can change build behavior and telemetry integrations; code changes are limited to tests.
Overview
Reverts dependency upgrades across contrib/test modules by downgrading OpenTelemetry (
go.opentelemetry.io/otel*) and related transitive deps (e.g.,x/sys,testify,goleak) incontrib/datadog,contrib/opentelemetry, andtest, updating correspondinggo.sumentries.contrib/opentelemetry/go.modandtest/go.modalso drop the declared Go version from1.24.0to1.23.0and add an explicittoolchain go1.23.6.Test tweaks remove conditional nil-checking around
d.SearchAttributesassertions intest/integration_test.go, and simplifyTestPinnedOverrideWithAutoUpgradeVersioningintest/worker_deployment_test.goby removing the retry loop aroundExecuteWorkflow.Written by Cursor Bugbot for commit 6db176d. This will update automatically on new commits. Configure here.