fix(spring-boot): use in-memory test server for non-root namespaces #2736
+70
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…\nFixes #2735.\n\n- Resolve TestWorkflowEnvironmentAdapter by type, fallback to correct bean name\n- Add regression test ensuring non-root namespaces use in-memory env even with connection.target set\n- Format code via spotlessApply
Contributor
Author
|
Note, I used AI to write the test, I told it to base the test off of sample |
| "spring.temporal.test-server.enabled=true", | ||
| "spring.temporal.connection.target=127.0.0.1:7233", | ||
| "spring.temporal.start-workers=false", | ||
| "spring.temporal.namespaces[0].namespace=pomegranate", |
Contributor
There was a problem hiding this comment.
Why "pomegranate"?
Contributor
Author
There was a problem hiding this comment.
Lol, the min reproducible sample used it and I thought it was good ¯_(ツ)_/¯ happy to change it to something else
Contributor
There was a problem hiding this comment.
Yeah other tests used more boring names like namespace0. Not something we need to be consistent with.
Quinn-With-Two-Ns
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2735.
What changed:
Why:
Breaking changes:
Tests: