Skip to content

Fix test server to return INVALID_ARGUMENT for UNHANDLED_COMMAND #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfateev merged 1 commit into from
Jan 7, 2026
+5 −2
Merged

Fix test server to return INVALID_ARGUMENT for UNHANDLED_COMMAND #2757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions temporal-sdk/src/test/java/io/temporal/client/functional/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public class MetricsTest {

@Before
public void setUp() {
registry.clear();
tagsNamespaceQueue =
replaceTags(TAGS_NAMESPACE, MetricsTag.TASK_QUEUE, testWorkflowRule.getTaskQueue());
}
Expand Down
6 changes: 4 additions & 2 deletions ...t-server/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,14 +488,16 @@ public void completeWorkflowTask(

if (unhandledCommand(request) || unhandledMessages(request)) {
// Fail the workflow task if there are new events or messages and a command tries to
// complete the
// workflow
// complete the workflow. Record the failure in history, then throw an error to the
// caller (matching real server behavior).
failWorkflowTaskWithAReason(
WorkflowTaskFailedCause.WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND,
null,
ctx,
request,
false);
ctx.setExceptionIfEmpty(
Status.INVALID_ARGUMENT.withDescription("UnhandledCommand").asRuntimeException());
return;
}

Expand Down
Loading