Skip to content

Deprecate namespace field in ChildWorkflowOptions #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjameswh merged 3 commits into from
Apr 7, 2026
Merged

Deprecate namespace field in ChildWorkflowOptions #2831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd28f92
Bump API to 1.62.7 and deprecate namespace in ChildWorkflowOptions
mjameswh Apr 7, 2026
6e52dcb
Suppress deprecation warnings for internal usages of proto namespace …
mjameswh Apr 7, 2026
38c2ac8
Merge branch 'master' into deprecate-cross-namespace-apis
mjameswh Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/statemachines/ChildWorkflowStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public static ChildWorkflowStateMachine newInstance(
attributes, metadata, startedCallback, completionCallback, commandSink, stateMachineSink);
}

@SuppressWarnings("deprecation")
private ChildWorkflowStateMachine(
StartChildWorkflowExecutionCommandAttributes startAttributes,
UserMetadata metadata,
Expand Down
1 change: 1 addition & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/statemachines/WorkflowStateMachines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,7 @@ public Functions.Proc newTimer(
* @param completionCallback invoked when child reports completion or failure
* @return cancellation callback that should be invoked to cancel the child
*/
@SuppressWarnings("deprecation")
public Functions.Proc startChildWorkflow(
StartChildWorkflowExecutionParameters parameters,
Functions.Proc2<WorkflowExecution, Exception> startedCallback,
Expand Down
14 changes: 14 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/workflow/ChildWorkflowOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public static final class Builder {

private Builder() {}

@SuppressWarnings("deprecation")
private Builder(ChildWorkflowOptions options) {
if (options == null) {
return;
Expand Down Expand Up @@ -91,7 +92,13 @@ private Builder(ChildWorkflowOptions options) {
* Specify namespace in which workflow should be started.
*
* <p>TODO: Resolve conflict with WorkflowClient namespace.
*
* @deprecated Cross-namespace child workflow execution is disabled by default in Temporal
* Server since version 1.30.1 (via {@code system.enableCrossNamespaceCommands} dynamic
* config flag). Setting this option will fail unless that flag is explicitly re-enabled on
* the server. This field may be removed at some point in the future.
*/
@Deprecated
public Builder setNamespace(String namespace) {
this.namespace = namespace;
return this;
Expand Down Expand Up @@ -447,6 +454,13 @@ private ChildWorkflowOptions(
this.priority = priority;
}

/**
* @deprecated Cross-namespace child workflow execution is disabled by default in Temporal Server
* since version 1.30.1 (via {@code system.enableCrossNamespaceCommands} dynamic config flag).
* Setting this option will fail unless that flag is explicitly re-enabled on the server. This
* field may be removed at some point in the future.
*/
@Deprecated
public String getNamespace() {
return namespace;
}
Expand Down
2 changes: 1 addition & 1 deletion temporal-serviceclient/src/main/proto
Open in desktop
Submodule proto updated 8 files
+0 −2 .github/PULL_REQUEST_TEMPLATE.md
+22 −0 openapi/openapiv2.json
+23 −0 openapi/openapiv3.yaml
+6 −3 temporal/api/command/v1/message.proto
+9 −0 temporal/api/common/v1/message.proto
+2 −0 temporal/api/history/v1/message.proto
+4 −0 temporal/api/workflowservice/v1/request_response.proto
+6 −6 temporal/api/workflowservice/v1/service.proto
1 change: 1 addition & 0 deletions temporal-test-server/src/main/java/io/temporal/internal/testservice/StateMachines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,7 @@ private static void childWorkflowCanceled(
ctx.addEvent(event);
}

@SuppressWarnings("deprecation")
private static void initiateChildWorkflow(
RequestContext ctx,
ChildWorkflowData data,
Expand Down
1 change: 1 addition & 0 deletions temporal-test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,7 @@ public void signalWithStartWorkflowExecution(
}
}

@SuppressWarnings("deprecation")
public void signalExternalWorkflowExecution(
String signalId,
SignalExternalWorkflowExecutionCommandAttributes commandAttributes,
Expand Down
Loading