Skip to content

Cleaned up flaky test. Updated licensing dependency #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 30, 2021
Merged

Cleaned up flaky test. Updated licensing dependency #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bd9d6a4
Update service client dependencies
Mar 16, 2021
acc66e4
Update temporal-sdk dependencies
Mar 16, 2021
7a4069c
Missed micrometer-core update
Mar 17, 2021
af82446
Merge remote-tracking branch 'upstream/master'
Mar 17, 2021
b00b312
Merge remote-tracking branch 'upstream/master'
Mar 29, 2021
e1ada5b
Merge remote-tracking branch 'upstream/master'
Mar 31, 2021
c6a874f
Merge remote-tracking branch 'upstream/master'
Apr 1, 2021
073cc38
Merge remote-tracking branch 'upstream/master'
Apr 4, 2021
5317b60
Merge remote-tracking branch 'upstream/master'
Apr 6, 2021
ff848ed
Merge remote-tracking branch 'upstream/master'
Apr 6, 2021
40fe165
Merge remote-tracking branch 'upstream/master'
Apr 9, 2021
85e132b
Merge remote-tracking branch 'upstream/master'
Apr 9, 2021
d44c3d5
Merge remote-tracking branch 'upstream/master'
Apr 12, 2021
837db19
Merge remote-tracking branch 'upstream/master'
Apr 14, 2021
f9860cd
Merge remote-tracking branch 'upstream/master'
Apr 16, 2021
190cc9d
Merge remote-tracking branch 'upstream/master'
Apr 27, 2021
6987488
Merge remote-tracking branch 'upstream/master'
Apr 30, 2021
9648a3b
Cleaned up this flaky unit test that was causing lots of problems + l…
Apr 30, 2021
211bdf8
Merge branch 'master' into master
vkoby Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporal-opentracing/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plugins {
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'com.palantir.git-version' version '0.12.2'
id 'maven-publish'
id 'signing'
Expand Down
2 changes: 1 addition & 1 deletion temporal-sdk/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plugins {
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'com.palantir.git-version' version '0.12.2'
id 'maven-publish'
id 'signing'
Expand Down
14 changes: 4 additions & 10 deletions ...sdk/src/test/java/io/temporal/workflow/interceptorsTests/InterceptorsExceptionsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
import io.temporal.common.interceptors.WorkflowClientCallsInterceptorBase;
import io.temporal.common.interceptors.WorkflowClientInterceptorBase;
import io.temporal.workflow.shared.SDKTestWorkflowRule;
import io.temporal.workflow.shared.TestOptions;
import io.temporal.workflow.shared.TestWorkflows;
import io.temporal.workflow.shared.TestWorkflows.NoArgsWorkflow;
import org.junit.Rule;
import org.junit.Test;

Expand All @@ -42,17 +41,12 @@ public class InterceptorsExceptionsTests {
WorkflowClientOptions.newBuilder()
.setInterceptors(new ExceptionOnStartThrowingClientInterceptor())
.validateAndBuildWithDefaults())
.setTestTimeoutSeconds(15)
.build();

@Test
public void testExceptionOnStart() {
TestWorkflows.NoArgsWorkflow workflowStub =
testWorkflowRule
.getWorkflowClient()
.newWorkflowStub(
TestWorkflows.NoArgsWorkflow.class,
TestOptions.newWorkflowOptionsWithTimeouts(testWorkflowRule.getTaskQueue()));
NoArgsWorkflow workflowStub =
testWorkflowRule.newWorkflowStubTimeoutOptions(NoArgsWorkflow.class);
try {
workflowStub.execute();
fail("Workflow call is expected to fail with an exception");
Expand All @@ -63,7 +57,7 @@ public void testExceptionOnStart() {
}
}

public static class WorkflowImpl implements TestWorkflows.NoArgsWorkflow {
public static class WorkflowImpl implements NoArgsWorkflow {
@Override
public void execute() {}
}
Expand Down
2 changes: 1 addition & 1 deletion temporal-serviceclient/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
id 'com.google.protobuf' version '0.8.16'
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'maven-publish'
id 'signing'
id 'de.marcphilipp.nexus-publish' version '0.4.0'
Expand Down
2 changes: 1 addition & 1 deletion temporal-testing-junit4/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plugins {
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'com.palantir.git-version' version '0.12.2'
id 'maven-publish'
id 'signing'
Expand Down
2 changes: 1 addition & 1 deletion temporal-testing-junit5/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plugins {
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'com.palantir.git-version' version '0.12.2'
id 'maven-publish'
id 'signing'
Expand Down
2 changes: 1 addition & 1 deletion temporal-testing/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plugins {
id 'java-library'
id 'net.ltgt.errorprone' version '2.0.1'
id 'org.cadixdev.licenser' version '0.5.1'
id 'org.cadixdev.licenser' version '0.6.0'
id 'com.palantir.git-version' version '0.12.2'
id 'maven-publish'
id 'signing'
Expand Down