Fix OpenTracingOptions.SpanBuilderProvider setTracer method#620
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Aug 5, 2021
Merged
Fix OpenTracingOptions.SpanBuilderProvider setTracer method#620Spikhalskiy merged 1 commit intotemporalio:masterfrom
Spikhalskiy merged 1 commit intotemporalio:masterfrom
Conversation
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
tsurdilo
requested review from
Spikhalskiy,
Sushisource,
mfateev and
vitarb
as code owners
Spikhalskiy
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tihomir Surdilovic tihomir@temporal.io
What was changed
Changed the signature of the OpenTracingOptions.SpanBuilderProvider setTracer method
Why?
This is done so we can use the builder approach to set both the tracer and the span builder provider (the same way)
Checklist
Closes
How was this tested: