Added poll thread count options #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| WorkflowServiceStubs service, | ||
| String namespace, | ||
| String taskList, | ||
| double taskListActivitiesPerSecond, |
Contributor
There was a problem hiding this comment.
Why pass this separately and not use SingleWorkerOptions value for taskListActivitiesPerSecond? https://github.com/temporalio/temporal-java-sdk/blob/master/src/main/java/io/temporal/internal/worker/SingleWorkerOptions.java#L45
Member
Author
There was a problem hiding this comment.
Good catch. Removed taskListActivitiesPerSecond from SinglePollerOptions as they don't apply to the workflow worker.
shawnhathaway
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options to configure number of polling threads:
WorkerFactoryOptions.workflowHostLocalPollThreadCountfor number of poller threads for cached workflows-
WorkerOptions.workflowPollThreadCountfor number of poller threads on a workflow task listWorkerOptions.activityPollThreadCountfor number of poller threads on an activity task listAlso fixed
WorkerOptions.taskListActivitiesPerSecondwhich configures global task list throttling.