SSL/TLS Support#90
Merged
shawnhathaway merged 5 commits intotemporalio:masterfrom May 22, 2020
shawnhathaway:tls
Merged
Conversation
mfateev
approved these changes
May 20, 2020
| .build(); | ||
| NettyChannelBuilder builder = | ||
| NettyChannelBuilder.forTarget(options.getTarget()) | ||
| .defaultLoadBalancingPolicy("round_robin"); |
Member
There was a problem hiding this comment.
let's add it to the options as well then.
Contributor
Author
There was a problem hiding this comment.
This is a required setting on our side afaik. Mind if I tackle this in a follow up change as we'd likely want to expose this on go-ask side as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds HTTPS/SSL/TLS support for clients by exposing two new options under WorkflowServiceStubs -