Issue 211. Test for readonly properties #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@shanginn have you tried functional tests with your changes? It fails, I think there are errors when running worker under RR. |
Contributor
Author
|
I did check it under my branch, and it went fine |
shanginn
force-pushed
the
feature-211-readonly-properties
branch
from
078fa66 to
608f46f
Compare
Contributor
Author
|
I rebased (or do you prefer merge?) this branch to the current master. in my fork all the test are good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I remember that readonly didn't work for me, but now they are working, so I created a test case for it. In order for it to work we need to add php 8.1 in CI matrix settings.
But php 8.1 will not work with current lower versions.
The questions is - do you want to add php 8.1 support? If no, I can just add the test and it will be waiting for the version upgrade.
There is another question: how should I go about testing this behavior: with marshaller or with payload converter? I created both, but I think that one of them is enough. Or both is good?
What was changed
Added test that covers readonly properties issue
Why?
Because issue is open and I though readonly properties would not work, but surprisingly they are working just fine
Checklist
Closes issue 221
How was this tested:
With unit test