Skip to content

feat: handle CanceledException as TimeoutException#709

Merged
xepozz merged 4 commits into
masterfrom
timeout-exc
Jun 8, 2026
Merged

feat: handle CanceledException as TimeoutException#709
xepozz merged 4 commits into
masterfrom
timeout-exc

Conversation

@xepozz
Copy link
Copy Markdown
Collaborator

@xepozz xepozz commented Feb 9, 2026

What was changed

Why?

Synced with another usage:

try {
$response = $this->client->PollWorkflowExecutionUpdate($request, $context);
} catch (TimeoutException|CanceledException $e) {
throw WorkflowUpdateRPCTimeoutOrCanceledException::fromTimeoutOrCanceledException($e);
}

As we can see the description in the \Temporal\Exception\Client\WorkflowUpdateRPCTimeoutOrCanceledException:

/**
* Occurs when an update call times out or is cancelled.
*
* @note this is not related to any general concept of timing out or cancelling a running update,
* this is only related to the client call itself.
*/

Others SDK:

Go
https://github.com/temporalio/sdk-go/blob/004415b923efb8f1eb723a579b53b718fd7b71e0/internal/internal_workflow_client.go#L2780
https://github.com/temporalio/sdk-go/blob/004415b923efb8f1eb723a579b53b718fd7b71e0/internal/internal_workflow_client.go#L2291

Java
https://github.com/temporalio/sdk-java/blob/187421b0e5e10b1dce62e661e5debeda45217e43/temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java#L437-L439
https://github.com/temporalio/sdk-java/blob/187421b0e5e10b1dce62e661e5debeda45217e43/temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java#L617
https://github.com/temporalio/sdk-java/blob/187421b0e5e10b1dce62e661e5debeda45217e43/temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java#L227

TypeScript
https://github.com/temporalio/sdk-typescript/blob/bebf54e2356a7b1d602d1a7ef4275621da1cf4a0/packages/client/src/workflow-client.ts#L895

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@xepozz xepozz requested a review from wolfy-j as a code owner February 9, 2026 14:37
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
php Ready Ready Preview, Comment Feb 9, 2026 2:38pm

Request Review

@xepozz xepozz requested review from a team and roxblnfk as code owners May 28, 2026 08:06
@wolfy-j
Copy link
Copy Markdown
Collaborator

wolfy-j commented Jun 8, 2026

Great

@xepozz xepozz merged commit 5638fac into master Jun 8, 2026
175 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants