Fairness Keys & Weights #1036
Fairness Keys & Weights #1036
Conversation
| 3. | ||
| """ | ||
|
|
||
| fairness_key: Optional[str] = None |
There was a problem hiding this comment.
Does it make sense to set one and not the other? Seems like the optionality matches the proto, but will it just fail if we do that, in which case it may be worth making it optional as a pair here?
There was a problem hiding this comment.
It does because of inheritance reasons I believe? I dunno, that's a good question though. @dnr ?
There was a problem hiding this comment.
At minimum, we don't want the pair anyway because it can make sense to set a key and have it assume the default weight.
There was a problem hiding this comment.
Yeah, they're inherited separately so it's probably best to treat them separately. And yes, a very common case will be to set a key without a weight (so it gets default 1.0). It doesn't really make sense to set a weight without a key though.
What was changed
Added fairness keys/weights to priority
Why?
New feature
Checklist
Closes
How was this tested:
Added test
Any docs updates needed?