Skip to content

Fix flaky test: test_workflow_patch_memoized #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 24, 2025
Merged

Fix flaky test: test_workflow_patch_memoized #1114

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17d74cf
Run the test a lot
tconley1428 Sep 23, 2025
473210c
Format
tconley1428 Sep 23, 2025
d392365
More logs
tconley1428 Sep 23, 2025
c947a79
Wait for post patch to also reach waiting signal
tconley1428 Sep 23, 2025
8f0d163
Remove debugging
tconley1428 Sep 23, 2025
15137bf
Try a simpler method of signals waiting for run completion
tconley1428 Sep 23, 2025
1edca1f
Revert "Try a simpler method of signals waiting for run completion"
tconley1428 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2946,12 +2946,21 @@ async def waiting_signal() -> bool:
task_queue=task_queue,
)

# Need to wait until it has gotten halfway through, otherwise the post_patch workflow may never complete
async def waiting_signal() -> bool:
return await post_patch_handle.query(
PatchMemoizedWorkflowPatched.waiting_signal
)

await assert_eq_eventually(True, waiting_signal)
Copy link
Contributor

@dandavison dandavison Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be beyond the call of duty, but it looks to me like this test was written before update existed and that a better way to implement this nowadays would be

    @workflow.update
    async def wait_until_waiting_signal_is_true(self) -> None:
        await workflow.wait_condition(lambda: self._waiting_signal)

...

        # Need to wait until it has gotten halfway through
        await pre_patch_handle.execute_update(
            PatchMemoizedWorkflowUnpatched.wait_until_waiting_signal_is_true
        )

[Tested and that seems to work]

Copy link
Contributor Author

@tconley1428 tconley1428 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, but I'll leave it as long as it is working.


# Send signal to both and check results
await pre_patch_handle.signal(PatchMemoizedWorkflowUnpatched.signal)
await post_patch_handle.signal(PatchMemoizedWorkflowPatched.signal)

# Confirm expected values
assert ["some-value"] == await pre_patch_handle.result()

assert [
"pre-patch",
"some-value",
Expand Down
Loading