fix: headers should always run through external storage#1396
Open
thakoreh wants to merge 1 commit intotemporalio:mainfrom
Open
fix: headers should always run through external storage#1396thakoreh wants to merge 1 commit intotemporalio:mainfrom
thakoreh wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
|
tconley1428
requested changes
Mar 26, 2026
Contributor
tconley1428
left a comment
tconley1428
left a comment
There was a problem hiding this comment.
This is not a sufficient change to address the issue. It happens in only a single place in the client and does not do so symmetrically across outbound and inbound payloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1395
The encode_headers parameter was gating the entire _transform_outbound_payload call in _apply_headers. This meant that when encode_headers=False, headers skipped both payload codec encoding AND external storage + size validation.
The fix adds an encode parameter to _transform_outbound_payload so external storage and validation always run, while codec encoding is still controlled by encode_headers.
Test added to verify external storage is called regardless of the encode flag.