Skip to content

More TMPRL1104 logging details#1469

Merged
jmaeagle99 merged 4 commits intotemporalio:mainfrom
jmaeagle99:more-1104-log-data
Apr 22, 2026
Merged

More TMPRL1104 logging details#1469
jmaeagle99 merged 4 commits intotemporalio:mainfrom
jmaeagle99:more-1104-log-data

Conversation

@jmaeagle99
Copy link
Copy Markdown
Contributor

What was changed

  • Include more data in the log message and structured logging of the TMPRL1104 log messages:
    • Include same data that workflow.logger would include, namely attempt, namespace, run_id, task_queue, workflow_id, and workflow_type.
    • Add workflow history size
    • Add download and update driver names
  • Add a log identifier that Temporal UI can use to refer to precise workflow task completion attempt consisting of the run ID, the completion event ID, and the attempt number.

Example log output:

[TMPRL1104] 019db345-f8f8-76c6-919f-631a00c4b031:4:1 Workflow task duration information ({'attempt': 1, 'namespace': 'default', 'run_id': '019db345-f8f8-76c6-919f-631a00c4b031', 'task_queue': '7a1a95c7-7170-45f5-a06b-b7d91dd06a5f', 'workflow_id': 'workflow-69cada2a-aa45-4280-9339-75fd32a3f0a3', 'workflow_type': 'ExtStoreWorkflow', 'event_id': 4, 'workflow_task_duration': '58.561ms', 'history_size': 472, 'payload_download_count': 1, 'payload_download_size': 1167, 'payload_download_duration': '21.199ms', 'payload_download_drivers': ['test-driver']})

Why?

  • Give customers more contextual data to better understand the precise workflow task to which the latency data is associated.
  • Allow Temporal UI to easily reference a specific task completion if workflow task latency is a concern.

Checklist

  1. How was this tested: Existing tests and updates to external storage tests.
  2. Any docs updates needed? No

@jmaeagle99 jmaeagle99 requested a review from a team as a code owner April 22, 2026 04:04
Comment thread temporalio/worker/_workflow.py
@jmaeagle99 jmaeagle99 enabled auto-merge (squash) April 22, 2026 22:05
@jmaeagle99 jmaeagle99 merged commit b466009 into temporalio:main Apr 22, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants