Fix race condition in test_update_payload_conversion#1473
Merged
tconley1428 merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
tconley1428
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed a race condition for this test here, and Copilot identified this comment as a source of concern:
From my limited understanding, any Workflow state written in an update validator is not durable and when we run this test in time-skipping mode this is even more problematic.
Note that with this change, we lose verification that a Workflow's run-result payload gets the WorkflowSerializationContext in this particular test, but that path is already covered by test_payload_conversion_calls_follow_expected_sequence_and_contexts (tests/test_serialization_context.py:191)