Address Flake in test_workflow_history_info#1545
Merged
Merged
Conversation
…workflow_history_info
tconley1428
approved these changes
May 19, 2026
THardy98
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add polling for expected history before sending final signal in test_workflow_history_info
What was changed
Wait for the first signal's timers to be committed so the next signal creates a post-timer workflow task with updated workflow.info().
Why?
This avoids a race where both signals are accepted before the worker processes the first one and both make it into the same activation. If that occurs, the query will have the stale history that the final signal is intended to avoid.
Checklist
I created a repro locally that:
After reproducing that way, I was able to confirm the fix that waiting for the signals to appear in history before sending the second signal addressed the issue.