Add trusted publishing release workflow#1575
Merged
Merged
Conversation
tconley1428
force-pushed
the
trusted-publishing-release-workflow
branch
from
97d2728 to
5114907
Compare
THardy98
reviewed
Jun 3, 2026
tconley1428
force-pushed
the
trusted-publishing-release-workflow
branch
3 times, most recently
from
d9892ed to
61f3d0e
Compare
tconley1428
force-pushed
the
trusted-publishing-release-workflow
branch
from
61f3d0e to
f8c2566
Compare
eamsden
approved these changes
Jun 3, 2026
Contributor
eamsden
left a comment
eamsden
left a comment
There was a problem hiding this comment.
- Minor issue caught by Codex that could interfere with smoke-testing re-releases
- Please confirm the final shape of workflow dispatch for the
release-publish.ymlworkflow.
otherwise LGTM
Comment on lines
+186
to
+199
| smoke_testpypi: | ||
| name: Smoke test TestPyPI package | ||
| needs: | ||
| - verify_artifacts | ||
| - publish_testpypi | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - uses: ./.github/actions/release-smoke-package | ||
| with: | ||
| version: ${{ needs.verify_artifacts.outputs.version }} | ||
| index-url: https://test.pypi.org/simple/ | ||
| extra-index-url: https://pypi.org/simple/ |
Contributor
There was a problem hiding this comment.
Should we matrix this to smoke test across the various build targets?
Contributor
Author
There was a problem hiding this comment.
We could, but it isn't something we've ever done for existing releases and we haven't seen any issues. I don't believe this smoke test has ever caught an actual problem in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation