Use ActivitySerializationContext when describing a Standalone Activity#1583
Merged
VegetarianOrc merged 3 commits intoJun 5, 2026
Merged
Conversation
maciejdudko
requested changes
Jun 5, 2026
Comment on lines
+696
to
+698
| activity_type = ( | ||
| resp.info.activity_type.name if resp.info.HasField("activity_type") else "" | ||
| ) |
Contributor
There was a problem hiding this comment.
activity_type is always present, the check is unnecessary.
Contributor
Author
There was a problem hiding this comment.
Done! Should we remove the same check from where the ActivityExecution and the ActivityExecutionDescription are built?
| data_converter=self._client.data_converter.with_context( | ||
| WorkflowSerializationContext( | ||
| ActivitySerializationContext( | ||
| namespace=self._client.namespace, |
There was a problem hiding this comment.
Is _client.namespace guaranteed to always be the namespace that the activity started with? I'm not clear about whether the client and the workflow/activity always have the same namespace (but I assume they do).
Contributor
Author
There was a problem hiding this comment.
Yes, you can't start/describe a workflow/activity unless you're auth'd against the namespace they are in. Except via Nexus of course 😎
maciejdudko
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Use ActivitySerializationContext when describing a Standalone Activity.
Why?
Using a WorkflowSerializationContext where the workflow_id is really an activity_id seems like a bug.