Fix for macOS OpenSSL cert validation issue #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
macos-openssl-fix
branch
from
6bb9808 to
9907179
Compare
cretz
force-pushed
the
macos-openssl-fix
branch
2 times, most recently
from
dc92d2e to
a5de492
Compare
cretz
force-pushed
the
macos-openssl-fix
branch
from
a5de492 to
e6f2387
Compare
cretz
force-pushed
the
macos-openssl-fix
branch
from
e6f2387 to
9633c51
Compare
chris-olszewski
approved these changes
Nov 7, 2025
| def run_in_background: { (?) -> untyped } -> (Thread | Fiber) | ||
|
|
||
| def find_free_port: -> String | ||
| def find_free_port: -> Integer |
Member
There was a problem hiding this comment.
Just noting for myself here, this is correct now as TCPServer#addr returns [String, Integer, String, String]
Member
Author
There was a problem hiding this comment.
Yeah, adding openssl as a gem caused RBS to get new sigs that changed a couple of things in this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
There is an issue validating certs on macOS for Ruby 3.4. This works around the issue until Ruby 3.4.8 is released which will have the proper fix. Not linking other issues here in description, see comment in GH workflow file for more details.
Issue often appears like: