Skip to content

Add support for more timeouts to Nexus operations#390

Merged
cretz merged 3 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:SDK-4956
Feb 18, 2026
Merged

Add support for more timeouts to Nexus operations#390
cretz merged 3 commits intotemporalio:mainfrom
Quinn-With-Two-Ns:SDK-4956

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Feb 18, 2026

Add support for more timeouts to Nexus operations

closes #389


Note

Medium Risk
Changes workflow command payloads and timeout semantics for Nexus operations, which could alter operation scheduling/timeout behavior and error surfaces. Coverage is improved via new tests, but runtime behavior depends on server/bridge support for the new timeout fields.

Overview
Adds support for schedule_to_start_timeout and start_to_close_timeout on workflow Nexus operations, plumbing the new options through Workflow::NexusClient/internal client, interceptor input, and ScheduleNexusOperation command construction.

Updates type signatures and docs for the new timeout parameters, bumps the local dev server version used in tests, and adds new Nexus timeout test cases covering schedule-to-start and start-to-close timeout failures.

Written by Cursor Bugbot for commit fbe6f89. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review February 18, 2026 08:10
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 18, 2026 08:10
if target_host.empty?
@server = Temporalio::Testing::WorkflowEnvironment.start_local(
logger: Logger.new($stdout),
dev_server_download_version: ENV.fetch('TEMPORAL_DEV_SERVER_VERSION', 'default'),
Copy link
Member

@cretz cretz Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather hardcode this if it's needed for tests to pass rather than have callers have to set an env var for tests to pass. We do this in other SDKs as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@cretz cretz merged commit 4fb3ddf into temporalio:main Feb 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for more timeouts to Nexus operations

2 participants

Comments