Add support for more timeouts to Nexus operations#390
Merged
cretz merged 3 commits intotemporalio:mainfrom Feb 18, 2026
Merged
Conversation
cretz
reviewed
Feb 18, 2026
temporalio/test/test.rb
Outdated
| if target_host.empty? | ||
| @server = Temporalio::Testing::WorkflowEnvironment.start_local( | ||
| logger: Logger.new($stdout), | ||
| dev_server_download_version: ENV.fetch('TEMPORAL_DEV_SERVER_VERSION', 'default'), |
Member
There was a problem hiding this comment.
Would rather hardcode this if it's needed for tests to pass rather than have callers have to set an env var for tests to pass. We do this in other SDKs as well.
ca10fd2 to
f0a0808
Compare
f0a0808 to
25a0541
Compare
25a0541 to
fbe6f89
Compare
cretz
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for more timeouts to Nexus operations
closes #389
Note
Medium Risk
Changes workflow command payloads and timeout semantics for Nexus operations, which could alter operation scheduling/timeout behavior and error surfaces. Coverage is improved via new tests, but runtime behavior depends on server/bridge support for the new timeout fields.
Overview
Adds support for
schedule_to_start_timeoutandstart_to_close_timeouton workflow Nexus operations, plumbing the new options throughWorkflow::NexusClient/internal client, interceptor input, andScheduleNexusOperationcommand construction.Updates type signatures and docs for the new timeout parameters, bumps the local dev server version used in tests, and adds new Nexus timeout test cases covering schedule-to-start and start-to-close timeout failures.
Written by Cursor Bugbot for commit fbe6f89. This will update automatically on new commits. Configure here.