Skip to content

Validate deployment options and test worker with versioning off and custom build ID#400

Merged
mjameswh merged 3 commits intomainfrom
worker-versioning-off-with-build-id
Mar 17, 2026
Merged

Validate deployment options and test worker with versioning off and custom build ID#400
mjameswh merged 3 commits intomainfrom
worker-versioning-off-with-build-id

Conversation

@mjameswh
Copy link
Contributor

Summary

  • Adds runtime validation rejecting default_versioning_behavior != UNSPECIFIED when use_worker_versioning is false, preventing stuck workflows caused by server-side rejection during workflow task completion
  • Adds integration test confirming a worker with use_worker_versioning: false and a custom build ID can successfully run workflows (build ID appears in history)
  • Adds unit test for the new validation

Related: temporalio/sdk-typescript#1962

Test plan

  • test_deployment_options_without_versioning — integration test passes against local server
  • test_rejects_versioning_behavior_when_versioning_off — validation test passes

🤖 Generated with Claude Code

…ustom build ID

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mjameswh mjameswh requested a review from a team as a code owner March 12, 2026 21:39
@mjameswh mjameswh enabled auto-merge (squash) March 17, 2026 23:12
@mjameswh mjameswh merged commit 9f7e628 into main Mar 17, 2026
7 checks passed
@mjameswh mjameswh deleted the worker-versioning-off-with-build-id branch March 17, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants