Notify stream regardless of server need for activity completion#1020
Merged
tconley1428 merged 2 commits intomasterfrom Sep 25, 2025
Merged
Notify stream regardless of server need for activity completion#1020tconley1428 merged 2 commits intomasterfrom
tconley1428 merged 2 commits intomasterfrom
Conversation
Sushisource
approved these changes
Sep 25, 2025
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Cool, glad we actually identified that fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
Without this there are scenarios where core is unable to shut down. If both sets of activities haven't been marked as completed, this completion may be required to do so, unblocking shutdown.
Checklist
Closes
How was this tested: