Make sure workers do not propagate retryable errors as fatal#353
Merged
Sushisource merged 5 commits intotemporalio:masterfrom Jul 18, 2022
Merged
Make sure workers do not propagate retryable errors as fatal#353Sushisource merged 5 commits intotemporalio:masterfrom
Sushisource merged 5 commits intotemporalio:masterfrom
Conversation
Member
Author
|
Will take a different approach - makes more sense to just drop these rather than retrying forever. |
Sushisource
changed the title
bergundy
approved these changes
Jul 15, 2022
lorensr
added a commit
to temporalio/sdk-typescript
that referenced
this pull request
Jul 29, 2022
- Turn down log level for this line ([#362](temporalio/sdk-rust#362)) - Fix bug where LA resolutions could trigger activations with no associated WFT ([#357](temporalio/sdk-rust#357)) - Don't allow activity completions with unset successful result payloads ([#356](temporalio/sdk-rust#356)) - Make sure workers do not propagate retryable errors as fatal ([#353](temporalio/sdk-rust#353)) - Fix null LA results becoming unparseable ([#355](temporalio/sdk-rust#355))
Sushisource
added a commit
to Sushisource/sdk-core
that referenced
this pull request
May 12, 2023
…lio#353) * Just swallow retryable errors which exceed the retry limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Workers should not bubble up retryable errors as fatal, rather they should prefer to just drop the task and let it expire naturally.
Why?
Robustness
Checklist
Closes
How was this tested:
New UT. Can't test specific scenario user reported b/c of Tonic internals, but it's not exactly complex.
Any docs updates needed?