Ensure resource tuner won't get WFTs stuck#835
Merged
Sushisource merged 5 commits intomasterfrom Oct 31, 2024
Merged
Conversation
Sushisource
force-pushed
the
resource-tuner-sticky-polls
branch
from
9034183 to
85033b2
Compare
mjameswh
approved these changes
Oct 31, 2024
Contributor
mjameswh
left a comment
mjameswh
left a comment
There was a problem hiding this comment.
LGTM, and I confirmed this fixes the flaky test in TS SDK. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Make sure the resource tuner is always willing to hand out a minimum of 1 slot for sticky and non-sticky WFT polls
Why?
Avoids a scenario where the sticky pollers can hog all the slots, starving normal poller.
Checklist
Closes [Bug] Resource Based Tuner is flaky - Does Tuner properly deal with sticky vs non-sticky pollers? #775
How was this tested:
Added IT
Any docs updates needed?