Don't retry on grpc message too large errors#916
Merged
tconley1428 merged 11 commits intomasterfrom May 15, 2025
Merged
Conversation
Sushisource
reviewed
May 14, 2025
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Overall idea looks good to me. Will want to add cloud test as discussed on Slack.
cretz
reviewed
May 15, 2025
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
No comment on the general Rust logic, just a couple of notes. Leaving code review to @Sushisource.
tconley1428
force-pushed
the
no_retry_on_grpc_too_large
branch
from
8060969 to
6e8ef10
Compare
Co-authored-by: Chad Retz <chad@temporal.io>
tconley1428
force-pushed
the
no_retry_on_grpc_too_large
branch
from
1f80d8e to
60746f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Don't retry on grpc message too large errors. Forward the error and fail the workflow task
Why?
Retries will not succeed, as they don't change the size of the message
Checklist
Closes [Bug] Do not auto-retry gRPC-message-size-too-large errors #462
How was this tested:
New worker tests
Any docs updates needed?