Fix flaky tests#922
Merged
Sushisource merged 8 commits intomasterfrom Jul 1, 2025
Merged
Conversation
Sushisource
force-pushed
the
hist-length-flake
branch
3 times, most recently
from
7d40f7d to
587c7b3
Compare
Sushisource
force-pushed
the
hist-length-flake
branch
from
587c7b3 to
f420ded
Compare
Sushisource
force-pushed
the
hist-length-flake
branch
from
a7ae400 to
282a23a
Compare
and can fail spuriously on windows.
Sushisource
force-pushed
the
hist-length-flake
branch
2 times, most recently
from
bc41cd6 to
f45e5b1
Compare
Sushisource
force-pushed
the
hist-length-flake
branch
from
f45e5b1 to
a3b9b4c
Compare
Sushisource
commented
Jun 28, 2025
Comment on lines
-632
to
-633
| #[test] | ||
| fn get_free_port_no_double() { |
Member
Author
There was a problem hiding this comment.
This test is unrealistic compared to the one below and provides no additional coverage. It could flake on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a handful of test flakes
Closes #752