Support for Unix sockets in HTTP connect proxy#984
Merged
cretz merged 2 commits intotemporalio:masterfrom Aug 22, 2025
Merged
Conversation
Sushisource
approved these changes
Aug 22, 2025
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
LGTM but I think you can save some boilerplate
| @@ -72,7 +83,7 @@ impl HttpConnectProxyOptions { | |||
| struct OverrideAddrConnector(String); | |||
|
|
|||
| impl Service<hyper::Uri> for OverrideAddrConnector { | |||
Member
There was a problem hiding this comment.
I believe you could get away with making OverrideAddrConnector generic over AsyncRead + AsyncWrite + Connection and not need the enum / implementations
Contributor
Author
There was a problem hiding this comment.
True, though there is added value in ProxyStream enum in that I use it in my homemade HTTP proxy server in test utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Checklist