Skip to content

Uniformize Activity's Context class to the contructor-args-as-fields notation #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

Uniformize Activity's Context class to the contructor-args-as-fields notation #1770

merged 1 commit into from
Aug 21, 2025

Conversation

@mjameswh
Copy link
Contributor

@mjameswh mjameswh commented Aug 21, 2025

What was changed

  • Converted activity's Context class to contructor-args-as-fields notation. This slightly reduces boilerplate code.

@mjameswh mjameswh requested a review from a team as a code owner August 21, 2025 15:43
@mjameswh mjameswh changed the title Lint: uniformize Activity's Context class to the contructor-args-as-f… Uniformize Activity's Context class to the contructor-args-as-fields notation Aug 21, 2025
Base automatically changed from nexus-cp-1 to main August 21, 2025 16:11
@mjameswh mjameswh changed the base branch from main to add-node-24 August 21, 2025 16:22
@mjameswh mjameswh changed the base branch from add-node-24 to main August 21, 2025 16:22
@mjameswh
Copy link
Contributor Author

mjameswh commented Aug 21, 2025

Given time constraints, I'm bypassing several CI failures, caused by:

  • Active GitHub Actions incident causing performance degradation, apparently affecting several of our linux runners
  • Known issue with Features test harness, fixed by this PR
  • Rare flake in starting ephemeral server, unrelated to this PR

@mjameswh mjameswh merged commit 3979d2a into main Aug 21, 2025
19 of 23 checks passed
@mjameswh mjameswh deleted the nexus-cp-2 branch August 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@THardy98 THardy98 THardy98 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjameswh @THardy98