Cleanup interceptors types and add type checking on wf completion promises #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
changed the title
THardy98
approved these changes
Aug 21, 2025
Contributor
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
Skimmed through - assuming it's the same change from the activity client + interceptors PR.
Left a couple nits but feel free to ignore
| internals?: WorkflowInternalsInterceptor[]; | ||
| } | ||
|
|
||
| // Workflow Inbound Calls Interceptors ///////////////////////////////////////////////////////////////////////////////// |
Contributor
There was a problem hiding this comment.
nit: comment format is not consistent with the Activity/Worker interceptor formats
Contributor
Author
There was a problem hiding this comment.
Well observed, but that's actually intentional. They are not the same level of separation 😉
But using section separators is a practice I just recently introduced, so it might still not be obvious yet, and it's totally possible that I've done it inconsistently elsewhere.
I'll leave as-is for now.
| readonly headers: Headers; | ||
| } | ||
|
|
||
| // Workflow Outbound Calls Interceptors ///////////////////////////////////////////////////////////////////////////////// |
| /** Input for WorkflowInternalsInterceptor.dispose */ | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-object-type | ||
| export interface DisposeInput {} | ||
| // Workflow Internals Interceptors ///////////////////////////////////////////////////////////////////////////////////// |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed