Merged
Conversation
chris-olszewski
force-pushed
the
olszewski/chore_type_imports
branch
from
6a0b684 to
3067224
Compare
chris-olszewski
force-pushed
the
olszewski/chore_type_imports
branch
from
3067224 to
ad1099f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Follow up for #2010, update our eslint settings to enforce identifiers only used for typing get imported as
import type.Done by enabling consistent-type-imports
Why?
General good hygiene to use
import typeto identify what imports are not present at runtime.Checklist
Closes N/A
How was this tested:
Changes eslint config, then ran
pnpm run lintto fixup the codebase.Any docs updates needed?
N/A