Skip to content

merge release/apikeys#228

Merged
mattkim merged 18 commits intomainfrom
mattkim/merge-apikeys
Aug 24, 2023
Merged

merge release/apikeys#228
mattkim merged 18 commits intomainfrom
mattkim/merge-apikeys

Conversation

@mattkim
Copy link
Copy Markdown
Member

@mattkim mattkim commented Aug 17, 2023

What was changed

merge release/apikeys

Why?

merge release/apikeys branch into main and use new feature flag settings

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

mattkim and others added 15 commits March 7, 2023 10:39
@mattkim
add initial implementation of request signatures (#146)
e6e736e
@mattkim
remove config on logout (#149) (#150)
8d8f0f1
@tminusplus
Add bearer token API keys and move authentication credentials into Pe…
141f97f 
…rRPCCredentials (#169)

* Add bearer token API keys and introduce PerRPCCredentials

* Rename insecure to allowInsecureTransport and fix err return

* Also rename WithInsecure to WithInsecureTransport

* Add UnimplementedRequestServiceServer to connection_test.go
@tminusplus @mattkim
Merge latest changes from main into release/apikeys (#171)
6bb2dcb 
* remove config on logout (#149)

* add create namespace command (#151)

* add namespace delete command (#158)

* bump version in tcld to v0.5.0 (#163)

* Tighten permissions on config files (#170)

---------

Co-authored-by: mattkim <matt@temporal.io>
@tminusplus
Hide EnableHMAC CLI flag to discourage experimental use (#172)
191416b 
* Hide the EnableHMAC flag to discourage use

* Remove duplicate DeleteConfigFile
@tminusplus
Split the concatenated API key arg (#174)
b3b3f61
@mattkim
small refactor to rename api-key-secret to api-secret-key (#175)
23c4857
@anekkanti
Merge branch 'main' into release/apikeys
7ea2a78
@anekkanti
add support for apikeys (#168)
69d5903
@tminusplus
Change experimental API key help messages to preview (#179)
3fc9161 
* Change experimental API key help messages to alpha

* Add APIKeyVersionTag to APIKeyID flag

* Rename alpha to preview to match communications
@anekkanti
support enable disable api keys (#181)
e40453a
@tminusplus
Refactor to single token, use authorization header, and remove reques…
7921219 
…t signatures (#184)

* Refactor to single token and remove request signatures

* Address review comments
@mattkim
update documentation to include API Key Preview information (#189)
065dbcd
@mattkim
copy user management readme to apikeys release (#211)
ae4b31b
@mattkim
merge main (#212)
6b70e81
@mattkim mattkim requested review from a team, anekkanti, shakeelrao and tminusplus August 17, 2023 15:57
shakeelrao
shakeelrao approved these changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shakeelrao shakeelrao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you plan on merging the proto change first?

@mattkim mattkim force-pushed the mattkim/merge-apikeys branch from 0a43361 to b4327e6 Compare August 17, 2023 23:21
@mattkim mattkim marked this pull request as ready for review August 17, 2023 23:28
@mattkim
Copy link
Copy Markdown
Member Author

mattkim commented Aug 18, 2023

LGTM. Do you plan on merging the proto change first?

merged in proto updates already here: #229

tminusplus
tminusplus approved these changes Aug 22, 2023
View reviewed changes
Comment thread app/flags.go
@mattkim mattkim merged commit 572dbe2 into main Aug 24, 2023
@mattkim mattkim deleted the mattkim/merge-apikeys branch August 24, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shakeelrao shakeelrao shakeelrao approved these changes

@anekkanti anekkanti Awaiting requested review from anekkanti

+1 more reviewer

@tminusplus tminusplus tminusplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattkim @tminusplus @shakeelrao @anekkanti